[Backport v4.1-branch] drivers: flash: sam: fix flash erase last page #86879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation for erasing pages in the flash_sam.c driver indicated a successful erase after exceeding the last page to be erased successfully. Since the last page has no proceeding page, the succeeded status was not set. This fix switches around the status to be set as succeeded before erase begins, to have the succeeded status cleared if page unlock or erase fails. Signed-off-by: Bjarki Arge Andreasen <[email protected]> (cherry picked from commit 9c6195a)
The flash erase-blocks property was a bit malformed, it has 254 pages of size 8192 after the first 8 pages of size 2048 to reach the total size of 2048K. This caused issues when trying to erase the last pages of the flash, which caused the flash erase_blocks test suite to fail. Adjust the erase-blocks to match the flash layout. Signed-off-by: Bjarki Arge Andreasen <[email protected]> (cherry picked from commit 6f45f68)
zephyrbot
added
area: Flash
platform: Microchip SAM
zephyrbot
requested review from
attie-argentum,
de-nordic,
mnkp,
nandojve,
pdgendt,
rghaddab and
stephanosio
pdgendt
approved these changes
Mar 10, 2025
nandojve
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 6f45f68~2..6f45f68 from #80800.
Fixes: #70344